Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79931?usp=email )
Change subject: soc/cavium/cn81xx/Kconfig: specify ECAM_MMCONF_BUS_NUMBER ......................................................................
soc/cavium/cn81xx/Kconfig: specify ECAM_MMCONF_BUS_NUMBER
The Cavium CN82xx SoC selects ECAM_MMCONF_SUPPORT, but doesn't set a value for ECAM_MMCONF_BUS_NUMBER which results in it defaulting to 0 which is wrong. Unsure what the correct value would be here, so set it to the maximum of 256 buses that a system with a single PCI segment group can have and add a TODO. This will be at least less wrong than the previous solution.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ic98381e2cc597cf23af249c71911545692e40f64 --- M src/soc/cavium/cn81xx/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/79931/1
diff --git a/src/soc/cavium/cn81xx/Kconfig b/src/soc/cavium/cn81xx/Kconfig index 368581f..68de1bc 100644 --- a/src/soc/cavium/cn81xx/Kconfig +++ b/src/soc/cavium/cn81xx/Kconfig @@ -39,4 +39,8 @@ config ECAM_MMCONF_BASE_ADDRESS default 0x848000000000
+# TODO: is this ECAM MMCONF bus number correct? +config ECAM_MMCONF_BUS_NUMBER + default 256 + endif