Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803a
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33623/8/src/superio/fintek/f81803a/...
File src/superio/fintek/f81803a/f81803a.h:
https://review.coreboot.org/c/coreboot/+/33623/8/src/superio/fintek/f81803a/...
PS8, Line 35: #define LDN_REG 0x07
: #define DEVICE_ENABLE_REG 0x30
: #define DEVICE_HIGH_ADDRESS_REG 0x60
: #define DEVICE_LOW_ADDRESS_REG 0x61
: #define DEVICE_IRQ_REG 0x70
this can probably be removed, since the code using this isn't here any more and the defines for those registers are also already present in the common pnp code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d336e76bccc38452b1b1aefef5d4a4f7ee129a8
Gerrit-Change-Number: 33623
Gerrit-PatchSet: 8
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Jul 2019 12:09:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
