Attention is currently required from: Shelley Chen, Tim Wawrzynczak, Julius Werner.
Veerabhadrarao Badiganti has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67884 )
Change subject: soc/qualcomm: Update the wait time for checking PCIe link up
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I did a firmware_ConsecutiveBoot test and it seemed to work ok, but I'll try to look into moving the […]
To answer Tim's query, yes Qualcomm IP has a status register to confirm the link is established or not. So we really don't need to wait for 100ms. This change looks good to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic67e7207c1e9f589b34705dc24f5d1ea423e2d56
Gerrit-Change-Number: 67884
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: Veerabhadrarao Badiganti
vbadigan@qualcomm.corp-partner.google.com
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 06 Oct 2022 04:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-MessageType: comment