Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add SPDs for Eldrid
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG@7
PS4, Line 7: spds
SPDs
Done
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG@19
PS4, Line 19: Original-Commit-Id:
Remove.
Good catch !
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee...
PS6, Line 3: $(abspath .)
ugh, i just tried this and it doesn't do what i thought :( […]
Yes, I noticed that (although it doesn't seem to break in Chromiumos)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 9
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 17:54:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment