Attention is currently required from: Jan Dabros, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75385?usp=email )
Change subject: mb/google/rex: Create ovis variant ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/75385/comment/3bdcbc9e_b9fb772c : PS4, Line 66: #define EC_ENABLE_MKBP_DEVICE
Good question. Looking at brask, these are still enabled, so you are right.
Done
File src/mainboard/google/rex/variants/baseboard/ovis/memory.c:
https://review.coreboot.org/c/coreboot/+/75385/comment/991d7c04_a2f4a9c9 : PS4, Line 16: .lpx_dq_map = {
These values are the same as on Rex. Let me double check whether these needs to be adjusted.
I checked it with Intel-provided tools and also with schematics. It's the same as on Rex.
File src/mainboard/google/rex/variants/baseboard/ovis/memory.c:
https://review.coreboot.org/c/coreboot/+/75385/comment/348f6457_340d2259 : PS5, Line 64: 0x66
please reconfirm this value?
I checked it and it's the same as in case of Rex, so the value is correct.