Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32772 )
Change subject: coreboot: add post code for invalid FSP
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32772/2/src/include/console/post_codes.h
File src/include/console/post_codes.h:
https://review.coreboot.org/#/c/32772/2/src/include/console/post_codes.h@341
PS2, Line 341: POST_INVALID_FSP
Is there any reason to make this FSP specific?
Maybe use:
POST_INVALID_VENDOR_BINARY
Or use POST_INVALID_ROM here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e359d4e8772c37922b1b779135e58c73bff6b4
Gerrit-Change-Number: 32772
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 14 May 2019 19:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment