[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: don't apply unconfigured USB2 PHY tune parameters

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43781 )

Change subject: soc/amd/picasso: don't apply unconfigured USB2 PHY tune parameters
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/43781/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43781/1//COMMIT_MSG@11 
PS1, Line 11: configured in the board's devicetree. Since all parameters being zero is
> I do agree that just using defaults and hoping for the best isn't good practice and that boards shou […]

For retrofitted coreboot ports (if that would be doable with picasso), determining the correct tuning settings is a bit hard. While defaults may not be the best, they're less likely to break something than all zeroes.