[coreboot-gerrit] Change in coreboot[master]: drivers/intel/usb4: Add driver for USB4 retimer device

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )

Change subject: drivers/intel/usb4: Add driver for USB4 retimer device
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
File src/drivers/intel/usb4/retimer/retimer.c:

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
PS12, Line 43: 0x03
> They support only get power state, but not set?

1 function beyond the standard query would be 0x3, if it's only the standard query, you can return 0 ("if [bit zero is] set to one, at least one additional function is supported"), meaning 0x1 would seem to be an invalid value here. Examples in the spec show returning 0 for just the query supported, and 3 returned for 1 function beyond the query. According to Intel's type-c acpi specs, other revs don't have other functions, so this should be 0.