Attention is currently required from: Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/60338 )
Change subject: soc/mediatek/mt8186: Add SPM firmware
......................................................................
Patch Set 1:
(1 comment)
File soc/mediatek/mt8186/spm_firmware.bin:
PS1:
Rex, I noticed that there are trailing spaces (0x20) at the end of the blob. Is it possible to fix that? If the size needs to be a multiple of 16, maybe just replace 0x20 with 0x00?
00002f00 70 63 6d 5f 73 75 73 70 65 6e 64 5f 6d 70 5f 76 |pcm_suspend_mp_v|
00002f10 31 31 30 39 20 20 20 20 20 20 20 20 20 20 20 20 |1109 |
00002f20
--
To view, visit
https://review.coreboot.org/c/blobs/+/60338
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I5a35f1c10886d31da9ba6dfec5ee2b3cf0664563
Gerrit-Change-Number: 60338
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 09:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment