Attention is currently required from: Shelley Chen, Furquan Shaikh. Prasad Malisetty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58683 )
Change subject: DO NOT SUBMIT: Proposed libpayload changes for PCI mmio ops support ......................................................................
Patch Set 3:
(4 comments)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/58683/comment/70803519_e456ab13 PS1, Line 416: SC7280
This should probably say Qualcomm rather than SC7280
Agree. I will update it in next patch version.
Thanks -Prasad
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/58683/comment/e1a7b3c5_8f91eaaa PS1, Line 500: if PCI
ECAM_MMCONF should definitely be under the PCI condition. […]
Sure, I will incorporate the changes in next patch version.
Thanks -Prasad
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/58683/comment/35ba3bca_ecd54d78 PS1, Line 102: pci->mmconf_base = CONFIG_MMIO_BASE_ADDRESS;
As mentioned in the discussion: https://review.coreboot. […]
Okay.
File src/soc/qualcomm/sc7280/Kconfig:
https://review.coreboot.org/c/coreboot/+/58683/comment/ec5eb4d6_f94fa6b6 PS1, Line 48: config MMIO_BASE_ADDRESS
Here is where we will define MMIO_BASE_ADDRESS and MMIO_LENGTH for sc7280 platforms.
Okay