Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31860 )
Change subject: mb/google/octopus: Create Bloog variant ......................................................................
Patch Set 4:
(4 comments)
Hi Justin and Karthik, I uploaded new patchset, please help review. Thanks
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/gpio.c:
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 4: 2018
2019
Done
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/include/variant/gpio.h:
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 4: * Copyright 2018 Google LLC
Furquan has already mentioned in one of the other files. […]
Done
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/overridetree.cb:
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 43:
I believe the gSPI config for TPM communication can be added. […]
Done
https://review.coreboot.org/#/c/31860/2/src/mainboard/google/octopus/variant... PS2, Line 45: device pci 16.0 off end # - I2C 0
It seems PEN is not present. If so, can you please the concerned GPIOs as NC. […]
Done, set GPIO as NC for LTE and PEN.