Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )
Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG@9
PS2, Line 9: amdfam10 does not yet
: work correctly without it
Why so?
It's either trying to access PCI devices that gets disabled or something still more whacky with HyperTransport.
Nowadays, with more of PCI inlined, I should be able to pinpoint the offending lines with preprocessor __file__, __line__.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34084
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ea37c097bbcc3cf5c0574c7d727eae4f5bee307
Gerrit-Change-Number: 34084
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 21:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment