Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44563 )
Change subject: soc/intel/jasperlake: Run pmc_set_acpi_mode() during .init in pmc_ops
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44563/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44563/3//COMMIT_MSG@15
PS3, Line 15: CL:42677
Nit: CB:42677. That links to the correct coreboot CL.
Done
https://review.coreboot.org/c/coreboot/+/44563/3/src/soc/intel/jasperlake/pm...
File src/soc/intel/jasperlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/44563/3/src/soc/intel/jasperlake/pm...
PS3, Line 81: pmc_set_acpi_mode
can be removed now.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f06e8b5da00eb05a34a6ce1de6d713005211c08
Gerrit-Change-Number: 44563
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 20 Aug 2020 01:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment