[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIF and PMIC driver support

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support
......................................................................

Patch Set 7:

(9 comments)

File src/soc/mediatek/mt8196/pmif_clk.c:

https://review.coreboot.org/c/coreboot/+/85126/comment/95c2d114_530fe418?usp... :
PS6, Line 117: min_cali_vali
> align with `BIOS_INFO`.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/dbcfe05c_46642d1b?usp... :
PS6, Line 149: if (freq_mhz > (target_clk * (1000 - CAL_MIS_RATE) / 1000)
             : 	    && freq_mhz < (target_clk * (1000 + CAL_MIS_RATE) / 1000)) {
             : 		return 0;
             : 	}
> `` […]

Done

File src/soc/mediatek/mt8196/pmif_spmi.c:

https://review.coreboot.org/c/coreboot/+/85126/comment/2ecec488_61e306d0?usp... :
PS6, Line 132: .
> remove `.`.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/9041845d_8bd72370?usp... :
PS6, Line 182: .
> remove `.`.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/fbbec4c7_4641dd4e?usp... :
PS6, Line 206: .
> remove `.`.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/f29d6891_6e91a074?usp... :
PS6, Line 235: */
> one space before `*`.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/7bf21299_44dbf467?usp... :
PS6, Line 239: */
> ditto

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/51ff6363_ec5db99d?usp... :
PS6, Line 249: .
> remove `.`.

Done

https://review.coreboot.org/c/coreboot/+/85126/comment/f9472041_4fafab24?usp... :
PS6, Line 317: channel
> channels

Done