Attention is currently required from: Bora Guvendik, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Pranava Y N, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )
Change subject: soc/intel/pantherlake: Update Touch Controller UPD params ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85199/comment/ff38f877_3ed0a652?usp... : PS3, Line 563: if (is_devfn_enabled(PCI_DEVFN_THC0)) { : s_cfg->ThcAssignment[0] = THC_0; : s_cfg->ThcMode[0] = config->thc_mode[0]; : s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0]; : } else { : s_cfg->ThcAssignment[0] = THC_NONE; : } : if (is_devfn_enabled(PCI_DEVFN_THC1)) { : s_cfg->ThcAssignment[1] = THC_1; : s_cfg->ThcMode[1] = config->thc_mode[1]; : s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1]; : } else { : s_cfg->ThcAssignment[1] = THC_NONE; : } : }
Bubrata, THC0/1 are used independent to each other. […]
in the first condidion: !is_devfn_enabled(PCI_DEVFN_THC0) && is_devfn_enabled(PCI_DEVFN_THC01)), both THC0 and THC1 needs to be turned on.
Also, it does not cover the case that both devices are enabled, though. The difference between (!THC0 and THC1) and (THC0 and THC1) is that in the first condition, it's ThcMode and ThcWakOnTouch is not relevant. Although THC0 not used, we will set THC0 to the same mode as THC1 so that PCI DID reflects the device of the same type.