Attention is currently required from: Reka Norman, Tim Wawrzynczak.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60995 )
Change subject: mb/google/brya: Add GPIO table for nissa
......................................................................
Patch Set 8: Code-Review+2
(3 comments)
Patchset:
PS8:
There are few open comments but I don't think these are related to the code directly, hence +2.
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/60995/comment/0969a9d9_7326c784
PS1, Line 374: NF1
Based on the discussion in http://b/214872254, it looks like we can swap the EC wake and IRQ pins. […]
EC pinmap has been updated : https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3419360
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/60995/comment/db8385be_8a40bc70
PS6, Line 109: EN_PP3300_UCAM_X
On nereid this controls both the UFC and WFC (net name is EN_PP3300_CAM_X). […]
If you want you can but I don't think it is necessary
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic923fd22abcaf7da0c607f66705a6e16c14cf8f2
Gerrit-Change-Number: 60995
Gerrit-PatchSet: 8
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 28 Jan 2022 09:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment