Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68405 )
Change subject: soc/intel/systemagent.c: Fix memory type reporting
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
This patch introduces a regression. If my tree contains this patch, the boot dies with the following last debug message:
[DEBUG] apm_control: Finalizing SMM.
Having a look with a HW debugger shows that the CPU has crashed completely. I am able to reproduce this issue on Elkhart Lake (mc_ehl2). Looks like Apollo Lake is affected, too (have not tesed myself). If I revert this and the following patch on top of master, everything is fine again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3d6f589c60e44a3dce9122d206397cac968647f
Gerrit-Change-Number: 68405
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 25 Oct 2022 05:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment