Attention is currently required from: Cliff Huang, Selma Bensaid, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57353 )
Change subject: soc/intel/common/cse: Add support for stitching CSE components
......................................................................
Patch Set 13:
(2 comments)
File src/southbridge/intel/common/firmware/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57353/comment/e4360557_28cbf59a
PS2, Line 21: $(shell $(top)/util/cse/create_cse.sh $@ $(call strip_quotes,$(CONFIG_CSE_INGREDIENTS)))
I replaced the command with '$(obj)/cse_fpt $(obj)/cse_ingredients/CSME print' for testing. […]
Done
File util/cse/create_cse.sh:
https://review.coreboot.org/c/coreboot/+/57353/comment/ae1ed600_9b35dc75
PS2, Line 30: cp ${IN_BINS_PATH}/old_me.bin ${OUT_BINS_PATH}/OLD_CSME
Do we really need this old_me. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8359cd49ad256703285e55bc4319c6e9c9fccb67
Gerrit-Change-Number: 57353
Gerrit-PatchSet: 13
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 08 Oct 2021 17:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Gerrit-MessageType: comment