Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from psp-verstage
......................................................................
Patch Set 8:
Patch Set 8:
Every verstage-y file with <arch/io.h> in its build dependencies is wrong.
build/verstage/drivers/pc80/rtc/mc146818rtc_boot.d
I am jumping to conclusion patchset #8 is not build-tested with enabled psp-verstage?
I expect the build to fail again with CMOS_POST=y or OPTION_TABLE=y
It's all tested.
psp_verstage supplies its own arch/io.h
https://review.coreboot.org/c/coreboot/+/41816/5/src/soc/amd/picasso/psp_ver...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I797b67394825172bd44ad1ee693a0c509289486b
Gerrit-Change-Number: 42062
Gerrit-PatchSet: 8
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 16:14:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment