[coreboot-gerrit] [S] Change in coreboot[master]: src/soc/intel: Document meaning of variables

[Maximilian Brune (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Paul Menzel, Angel Pons.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71664 )

Change subject: src/soc/intel: Document meaning of variables
......................................................................

Patch Set 2:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/71664/comment/3a29b7cd_02ef7bdf 
PS1, Line 7: Add in-code documentation
> Maybe: Add descriptions for some technical concepts

Done

File src/soc/intel/alderlake/chip.h:

https://review.coreboot.org/c/coreboot/+/71664/comment/4dbbef38_4acb7567 
PS1, Line 156: 	DDI_ENABLE_HPD = 1 << 1, // Hot Plug Detect
> Looks like the file uses C-style comments, most of coreboot uses C-style comments too.

I prefer not adding an entire line for each of these comments. Also its a single line comment, but that is just personal preference.

File src/soc/intel/common/block/include/intelblocks/meminit.h:

https://review.coreboot.org/c/coreboot/+/71664/comment/7b065205_70a47a2a 
PS1, Line 26: 	MEM_TOPO_DIMM_MODULE = BIT(1), // memory is composed of DIMM modules
> C-style comments

Ack