Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6472
-gerrit
commit d129a5b15b4db5914b3e8f0fbeee686acae39949 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Sun Aug 3 17:53:27 2014 +1000
northbridge/intel/sandybridge/raminit_native.c: Uninitialized var
Initialise length before return and give a new line before the if condition as to make clear that it is not part of the for-loop construct.
Change-Id: Ia5cee1fd204220adbcfedd9ac3306b8282eb8f90 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/northbridge/intel/sandybridge/raminit_native.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c index 9b49f11..177fb41 100644 --- a/src/northbridge/intel/sandybridge/raminit_native.c +++ b/src/northbridge/intel/sandybridge/raminit_native.c @@ -1657,10 +1657,12 @@ static struct run get_longest_zero_run(int *seq, int sz) } ls = i + 1; } + if (bl == 0) { ret.middle = sz / 2; ret.start = 0; ret.end = sz; + ret.length = bl; ret.all = 1; return ret; }