Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31310 )
Change subject: sb/intel/i82801gx/lpc: Use macros instead of magic numbers ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31310/3/src/southbridge/intel/i82801gx/lpc.c File src/southbridge/intel/i82801gx/lpc.c:
https://review.coreboot.org/#/c/31310/3/src/southbridge/intel/i82801gx/lpc.c... PS3, Line 263: should use read_pmbase32
https://review.coreboot.org/#/c/31310/3/src/southbridge/intel/i82801gx/lpc.c... PS3, Line 268: should use write_pmbase32
https://review.coreboot.org/#/c/31310/3/src/southbridge/intel/i82801gx/lpc.c... PS3, Line 489: should use lpc_get_pmbase(), probably out of scope of this patch