Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35471 )
Change subject: soc/mediatek/mt8183: Refactor DRAM init by bit fields API ......................................................................
Patch Set 14:
(1 comment)
DRAM works on my device.
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... PS14, Line 502: 0, : TEST2_4_TESTSSOXTALKPAT, 0, This is really the reason I prefer to move to new API.
Reading the original code, we see '1' applied to 3 different names, but the actual behavior is setting two '0' and one '1'.
I spent 2 hours debugging this and reviewed several times but still can't see that error.