build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: Fix bootsplash display code for optionroms ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/bootsplash... File src/device/oprom/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/bootsplash... PS2, Line 18: int oprom_set_bootsplash(unsigned char *framebuffer, trailing whitespace
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/bootsplash... PS2, Line 19: u16 x_resolution, u16 y_resolution, u16 fb_resolution); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/bootsplash... PS2, Line 19: u16 x_resolution, u16 y_resolution, u16 fb_resolution); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/bootsplash... File src/device/oprom/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/bootsplash... PS2, Line 29: trailing whitespace
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/realmode/x... PS2, Line 377: printk(BIOS_WARNING, trailing whitespace
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/realmode/x... PS2, Line 378: "VBE: Bootsplash could not be decoded. jpeg_decode returned %d.\n", trailing whitespace
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/yabel/vbe.... File src/device/oprom/yabel/vbe.c:
https://review.coreboot.org/c/coreboot/+/34537/2/src/device/oprom/yabel/vbe.... PS2, Line 756: "VBE: Bootsplash could not be decoded. jpeg_decode returned %d.\n", trailing whitespace