Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84537?usp=email )
Change subject: mainboard/google/fatcat: Update SoC to Panther Lake ......................................................................
mainboard/google/fatcat: Update SoC to Panther Lake
This commit updates the fatcat mainboard to use the Panther Lake SoC instead of Meteor Lake.
The changes include:
- Selecting the `SOC_INTEL_PANTHERLAKE_U_H` config option. - Updating the `mainboard_update_soc_chip_config()` function to use the `soc_intel_pantherlake_config` struct. - Updating the devicetree to use the `soc/intel/pantherlake` chip. - Updating variant header files to reflect the SoC change.
This update enables support for the Panther Lake SoC and its features on the fatcat mainboard.
BUG=b:347669091 TEST=Able to build google/fatcat.
Change-Id: Ie0c6257dfb9dd1f627472ad220614f9b24c911ef Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84537 Reviewed-by: Pranava Y N pranavayn@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/mainboard.c M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb M src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h 4 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Pranava Y N: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 42a839c..960ab14 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -20,6 +20,7 @@ select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 select SOC_INTEL_CSE_SEND_EOP_ASYNC + select SOC_INTEL_PANTHERLAKE_U_H
config BOARD_GOOGLE_BASEBOARD_FATCAT def_bool n @@ -28,7 +29,6 @@ select MAINBOARD_HAS_CHROMEOS select MEMORY_SOLDERDOWN select SOC_INTEL_IOE_DIE_SUPPORT - select SOC_INTEL_METEORLAKE_U_H select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50
diff --git a/src/mainboard/google/fatcat/mainboard.c b/src/mainboard/google/fatcat/mainboard.c index 107ee8d..55b9e4c 100644 --- a/src/mainboard/google/fatcat/mainboard.c +++ b/src/mainboard/google/fatcat/mainboard.c @@ -16,12 +16,12 @@ /* default implementation does nothing */ }
-void mainboard_update_soc_chip_config(struct soc_intel_meteorlake_config *config) +void mainboard_update_soc_chip_config(struct soc_intel_pantherlake_config *config) { variant_update_soc_chip_config(config); }
-__weak void variant_update_soc_chip_config(struct soc_intel_meteorlake_config *config) +__weak void variant_update_soc_chip_config(struct soc_intel_pantherlake_config *config) { /* default implementation does nothing */ } diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb b/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb index 9f4f3455..73b99db 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb @@ -1,3 +1,3 @@ -chip soc/intel/meteorlake +chip soc/intel/pantherlake device domain 0 on end end diff --git a/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h index 8a97d00..27fd8b7 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h @@ -22,7 +22,7 @@ void variant_get_spd_info(struct mem_spd *spd_info); int variant_memory_sku(void); bool variant_is_half_populated(void); -void variant_update_soc_chip_config(struct soc_intel_meteorlake_config *config); +void variant_update_soc_chip_config(struct soc_intel_pantherlake_config *config);
/* Get soc power limit config struct for current CPU sku */ struct soc_power_limits_config *variant_get_soc_power_limit_config(void);