Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43310 )
Change subject: soc/amd/picasso: Add dummy spinlock for psp_verstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43310/2/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/43310/2/src/soc/amd/picasso/psp_ver...
PS2, Line 15: #define boot_cpu() 1
This is confusing since <smp/node.h> declares […]
Can we fix these up by having a notion of STAGE_SUPPORTS_SMP ? That we can provide default implementations for all these in the include/smp/spinlock.h. We nearly have that aside from CONFIG(SMP) is global. I think we could probably just add a Kconfig per stage that indicates if STAGE_SUPPORTS_SMP or STAGE_SINGLE_CPU or some such. What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea6f31e500e1b26f0b974c6eaa486209b9c81459
Gerrit-Change-Number: 43310
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 10 Jul 2020 17:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment