Attention is currently required from: Jon Murphy, Nick Vaccaro.
Subrata Banik has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/hatch/variants/dratini/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83745/comment/cf0652c1_487d572c?usp... :
PS4, Line 29: }
Not sure what happened to my comment....I didn't add a default case because I was following the style in variant.c. Would you prefer to match style or add the default case?
i have seen cases when Intel asks us to fix the missing default/missing else blobk while they are running code analysers.
Other than that, I'm good with anything
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 02 Aug 2024 17:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com