Attention is currently required from: Martin Roth, Mathew King, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51043 )
Change subject: mb/google/guybrush: Enable Chrome EC
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51043/comment/ead4d8b5_4dfe69d5
PS4, Line 22: mainboard_ec_init
How about this, lets call ec_init after configure_gpios and we can wait to move the gpios to psp_ver […]
I guess we are going to configure espi in bootblock anyway, so it doesn't really matter here. I'll just resolve this for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51043
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb
Gerrit-Change-Number: 51043
Gerrit-PatchSet: 6
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 21:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment