15 Dec
2020
15 Dec
'20
2:08 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45686 )
Change subject: mb/prodrive/hermes: Improve board config EEPROM handling ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45686/5/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h:
https://review.coreboot.org/c/coreboot/+/45686/5/src/mainboard/prodrive/herm... PS5, Line 51: #define READ_EEPROM(a, b, x, y) \ Macros with flow control statements should be avoided
--
To view, visit https://review.coreboot.org/c/coreboot/+/45686
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f83d1ddb455a3d0aaec9757666d161f2091cec2
Gerrit-Change-Number: 45686
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 14:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment