Attention is currently required from: Paul Menzel, Sergii Dmytruk, Timothy Pearson, Ron Minnich. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57082 )
Change subject: src/mainboard/emulation/qemu-power9: require hb-mode=on ......................................................................
Patch Set 16:
(1 comment)
File src/arch/ppc64/rom_media.c:
https://review.coreboot.org/c/coreboot/+/57082/comment/8e16a566_266f6319 PS16, Line 6: MEM_REGION_DEV_RO_INIT(0x8000000, CONFIG_ROM_SIZE); To get more hardware-like experience, this should be at 0x00060300FC000000 (note that LPC base is defined in arch/io.h, maybe define an offset to flash there and include it here) and QEMU should be started with `-bios build/coreboot.rom --drive file=build/coreboot.rom,if=mtd`. `bios` is what is initially loaded to cache (HW) or RAM (QEMU) so technically passing just bootblock file would suffice, and `drive ...if=mtd` is what is mounted as flash device. Even though it complicates QEMU command line, it would allow to make more code shared between QEMU and real hardware in the future.
One quirk is that QEMU always mounts it at the address mentioned above regardless of mounted file size, while hardware maps it so flash ends at 0x00060300FCFFFFFF. I don't know of any POWER9 platform that use different flash size than 64MB so it shouldn't matter.