Attention is currently required from: Pratik Vishwakarma, Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57012 )
Change subject: soc/amd/common: Correct device list format
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57012/comment/61dd3fbf_c282e455
PS1, Line 7: soc/amd/common: Correct device list format
soc/amd/common/upep.asl: Correct device list format
https://review.coreboot.org/c/coreboot/+/57012/comment/9c29a047_618b5d27
PS1, Line 9: Use correct format for constraint list as expected
: by kernel driver. With this change, kernel is able
: to correctly list dummy device in constraint list.
The lines can stretch to 72 characters. Please reflow the message accordingly.
https://review.coreboot.org/c/coreboot/+/57012/comment/6f3a0e60_9aa82cff
PS1, Line 12:
Please list
BUG=b:194687976
TEST=Which device you tested it on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Gerrit-Change-Number: 57012
Gerrit-PatchSet: 1
Gerrit-Owner: Pratik Vishwakarma
Pratik.Vishwakarma@amd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Pratik Vishwakarma
Pratik.Vishwakarma@amd.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 18 Aug 2021 07:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment