Attention is currently required from: Martin Roth. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62937 )
Change subject: makechips.sh: Clean up shellcheck errors and formatting ......................................................................
Patch Set 1:
(6 comments)
File makechips.sh:
https://review.coreboot.org/c/em100/+/62937/comment/e998b478_b53b5a92 PS1, Line 33: FILE ${FILE}?
https://review.coreboot.org/c/em100/+/62937/comment/e84f82f1_2577007a PS1, Line 36: FILE ${FILE}?
https://review.coreboot.org/c/em100/+/62937/comment/fc8c2a96_11f6e74b PS1, Line 37: URL ${URL}? ${FILE}?
https://review.coreboot.org/c/em100/+/62937/comment/c55b0812_5e9348db PS1, Line 40: FILE ${FILE} ?
https://review.coreboot.org/c/em100/+/62937/comment/f6dbac1e_7e28176e PS1, Line 46: VERSION should this be ${VERSION} ?
https://review.coreboot.org/c/em100/+/62937/comment/187cf0af_b63a7f30 PS1, Line 57: i ${i} ?