Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31505 )
Change subject: src/soc/intel/cannonlake: Add PsysPmax setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31505/2/src/soc/intel/cannonlake/fsp_params....
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31505/2/src/soc/intel/cannonlake/fsp_params....
PS2, Line 93: printk(BIOS_DEBUG, "psys_pmax = %dW\n", tconfig->PsysPmax);
How is this helpful? Now this would just end up printing the default value in tconfig->PsysPmax?
sorry, my bad..
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31505
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia88ea17bc661a388c5b9bc3e59abc27c9f262977
Gerrit-Change-Number: 31505
Gerrit-PatchSet: 2
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 03:52:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment