build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36614 )
Change subject: soc/intel/common/sa: Properly guard the FSP-TOLUM cbmem_top implementation
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36614/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/cbmem.c:
https://review.coreboot.org/c/coreboot/+/36614/2/src/soc/intel/common/block/...
PS2, Line 22: return (void *)(uintptr_t)range_entry_end(&tolum);
code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36614/2/src/soc/intel/common/block/...
PS2, Line 22: return (void *)(uintptr_t)range_entry_end(&tolum);
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb3534b88de4f7b6fc39675a77461265605e56e
Gerrit-Change-Number: 36614
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Nov 2019 20:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment