build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35018 )
Change subject: soc/amd/common/block: Create new SPI code ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35018/1/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi_ctrl.c:
https://review.coreboot.org/c/coreboot/+/35018/1/src/soc/amd/common/block/sp... PS1, Line 171: static int amd_xfer_vectors( struct spi_op vectors[], size_t count) space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35018/1/src/soc/amd/common/block/sp... PS1, Line 274: int (*probe) (const struct spi_slave *spi, u8 *idcode, Unnecessary space before function pointer arguments