29 Nov
2021
29 Nov
'21
4:48 a.m.
Attention is currently required from: David Wu, Tim Wawrzynczak, Paul Menzel, Alan Huang. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configure the ISOLATE pin of LAN ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/abe247e9_6e952180 PS5, Line 86: register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)"
Yes. The ISOLATE pin is active low. […]
Thanks for clarification. I don't have concern for this now. Please modify the gpio pin to GPP_A7
--
To view, visit https://review.coreboot.org/c/coreboot/+/58105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e82dbc1e6c68cbd84b603adc7fdc3ee1d4d3392
Gerrit-Change-Number: 58105
Gerrit-PatchSet: 9
Gerrit-Owner: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 03:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee zhuohao@google.com
Comment-In-Reply-To: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-MessageType: comment