Attention is currently required from: Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 )
Change subject: console: Handle verstage as "first non-bootblock stage" ......................................................................
Patch Set 1:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/56210/comment/fd5d3ea5_be0612d7 PS1, Line 15: #endif
I believe the NO_BOOTBLOCK_CONSOLE part here already made no sense to begin with, and this would be […]
The idea was to give systems that don't use get_option() before the first console output a chance to print something in case something behind get_option() is broken. That was based on your complexity arguments and it was the historic behavior before CB:45765, although, not explicitly.
I know it's not perfect, if a particular system runs into the error earlier, this FIRST_CONSOLE logic won't help. But other systems get a chance. ENV_INITIAL_STAGE doesn't help either wrt. "the first output on the console". I don't mind if we just remove this logic, no strong feelings.
(sorry for missing SEPARATE_VERSTAGE, I should have been aware)