Attention is currently required from: Jamie Ryu, Maulik V Vaghela, Selma Bensaid, Tim Wawrzynczak, Ronak Kanabar, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54334 )
Change subject: soc/intel/alderlake: Add configurable value for UsbTcPortEn ......................................................................
Patch Set 6:
(6 comments)
File src/soc/intel/alderlake/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120774): https://review.coreboot.org/c/coreboot/+/54334/comment/48947437_b9dc110a PS6, Line 44: * Specifies which Type-C Ports are enabled on the system code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120774): https://review.coreboot.org/c/coreboot/+/54334/comment/4b78cc11_3940d89f PS6, Line 45: * each bit represents a port starting at 0 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120774): https://review.coreboot.org/c/coreboot/+/54334/comment/8d87d99f_8e315403 PS6, Line 46: * Example: set value to 0x3 for ports 0 and 1 to be enabled code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120774): https://review.coreboot.org/c/coreboot/+/54334/comment/1643e21b_986b0711 PS6, Line 47: */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120774): https://review.coreboot.org/c/coreboot/+/54334/comment/333dd71e_6fdfc732 PS6, Line 48: uint8_t UsbTcPortEn; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120774): https://review.coreboot.org/c/coreboot/+/54334/comment/2ee34b88_edfe7aa8 PS6, Line 48: uint8_t UsbTcPortEn; please, no spaces at the start of a line