build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31381 )
Change subject: soc/intel/skylake: Define VR settings ......................................................................
Patch Set 1:
(88 comments)
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 22: [VR_SYSTEM_AGENT] = { please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 23: .vr_config_enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 23: .vr_config_enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 24: .psi1threshold = VR_CFG_AMP(20), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 24: .psi1threshold = VR_CFG_AMP(20), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 25: .psi2threshold = VR_CFG_AMP(5), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 25: .psi2threshold = VR_CFG_AMP(5), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 26: .psi3threshold = VR_CFG_AMP(1), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 26: .psi3threshold = VR_CFG_AMP(1), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 27: .psi3enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 27: .psi3enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 28: .psi4enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 28: .psi4enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 29: .imon_slope = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 29: .imon_slope = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 30: .imon_offset = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 30: .imon_offset = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 31: .icc_max = VR_CFG_AMP(6), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 31: .icc_max = VR_CFG_AMP(6), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 32: .voltage_limit = 1520, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 32: .voltage_limit = 1520, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 33: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 34: [VR_IA_CORE] = { please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 35: .vr_config_enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 35: .vr_config_enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 36: .psi1threshold = VR_CFG_AMP(20), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 36: .psi1threshold = VR_CFG_AMP(20), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 37: .psi2threshold = VR_CFG_AMP(5), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 37: .psi2threshold = VR_CFG_AMP(5), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 38: .psi3threshold = VR_CFG_AMP(1), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 38: .psi3threshold = VR_CFG_AMP(1), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 39: .psi3enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 39: .psi3enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 40: .psi4enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 40: .psi4enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 41: .imon_slope = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 41: .imon_slope = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 42: .imon_offset = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 42: .imon_offset = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 43: .icc_max = VR_CFG_AMP(70), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 43: .icc_max = VR_CFG_AMP(70), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 44: .voltage_limit = 1520, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 44: .voltage_limit = 1520, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 45: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 46: [VR_GT_UNSLICED] = { please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 47: .vr_config_enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 47: .vr_config_enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 48: .psi1threshold = VR_CFG_AMP(20), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 48: .psi1threshold = VR_CFG_AMP(20), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 49: .psi2threshold = VR_CFG_AMP(5), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 49: .psi2threshold = VR_CFG_AMP(5), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 50: .psi3threshold = VR_CFG_AMP(1), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 50: .psi3threshold = VR_CFG_AMP(1), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 51: .psi3enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 51: .psi3enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 52: .psi4enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 52: .psi4enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 53: .imon_slope = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 53: .imon_slope = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 54: .imon_offset = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 54: .imon_offset = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 55: .icc_max = VR_CFG_AMP(31), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 55: .icc_max = VR_CFG_AMP(31), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 56: .voltage_limit = 1520, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 56: .voltage_limit = 1520, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 57: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 58: [VR_GT_SLICED] = { please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 59: .vr_config_enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 59: .vr_config_enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 60: .psi1threshold = VR_CFG_AMP(20), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 60: .psi1threshold = VR_CFG_AMP(20), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 61: .psi2threshold = VR_CFG_AMP(5), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 61: .psi2threshold = VR_CFG_AMP(5), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 62: .psi3threshold = VR_CFG_AMP(1), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 62: .psi3threshold = VR_CFG_AMP(1), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 63: .psi3enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 63: .psi3enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 64: .psi4enable = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 64: .psi4enable = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 65: .imon_slope = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 65: .imon_slope = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 66: .imon_offset = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 66: .imon_offset = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 67: .icc_max = VR_CFG_AMP(31), code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 67: .icc_max = VR_CFG_AMP(31), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 68: .voltage_limit = 1520, code indent should use tabs where possible
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 68: .voltage_limit = 1520, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31381/1/src/soc/intel/cannonlake/vr_config.c... PS1, Line 69: }, please, no spaces at the start of a line