[coreboot-gerrit] [XS] Change in coreboot[main]: util/hda-decoder: Protect 'fields' slice if empty string

[Angel Pons (Code Review)]

Attention is currently required from: Maxim, Nicholas Sudsgaard.

Angel Pons has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/84101?usp=email )

Change subject: util/hda-decoder: Protect 'fields' slice if empty string
......................................................................

Patch Set 2:

(1 comment)

File util/hda-decoder/main.go:

https://review.coreboot.org/c/coreboot/+/84101/comment/a8b4b833_b17b3a2d?usp... :
PS2, Line 73: Something went wrong
> Let's be a little bit more descriptive than that. […]

Yes, the error handling isn't great, but let's not forget that the point of this change is to fix a crash/panic. I would prefer to get it submitted as-is into the coreboot release (IIRC it's going to happen soon).

The error message can be improved in a follow-up change. I would consider logging the output of `scanner.Text()` for example (best discussed in a follow-up).