Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )
Change subject: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb
......................................................................
Patch Set 18: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45340/18/src/soc/amd/picasso/acpi.c
File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45340/18/src/soc/amd/picasso/acpi.c...
PS18, Line 298: }
nit: add a new line between the end of the function and the comment.
https://review.coreboot.org/c/coreboot/+/45340/18/src/soc/amd/picasso/acpi.c...
PS18, Line 341: cstate_info
Should you zero this one out too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f4db3c0c2048ea1d6c6ce55f5e252cb15598514
Gerrit-Change-Number: 45340
Gerrit-PatchSet: 18
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 15:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment