Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31980 )
Change subject: mb/google/hatch/variants: Add DPTF based Fan control
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31980/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/acpi/dptf.asl:
https://review.coreboot.org/#/c/31980/1/src/mainboard/google/hatch/variants/...
PS1, Line 55: #ifdef DPTF_ENABLE_FAN_CONTROL
Let's not add this since it is defined just a few lines up.
https://review.coreboot.org/#/c/31980/1/src/mainboard/google/hatch/variants/...
PS1, Line 84: B0D4
TCPU?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c2a679dc67eecb17098ce0f0c9703c679473a2d
Gerrit-Change-Number: 31980
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Mar 2019 05:02:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment