Erin Lo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31835 )
Change subject: google/kukui: Init SSPM
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31835/7/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/31835/7/src/mainboard/google/kukui/...
PS7, Line 29: cbfs-files-y += sspm.bin
...and this should go in mt8183/Makefile.inc.
Done
https://review.coreboot.org/c/coreboot/+/31835/7/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/31835/7/src/mainboard/google/kukui/...
PS7, Line 79: sspm_init();
The SSPM would be needed for all MT8183 board, right? In that case, I think this should go in mt8183 […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9285034fc8ce38b40134f5eb7b986a663175e620
Gerrit-Change-Number: 31835
Gerrit-PatchSet: 7
Gerrit-Owner: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Erin Lo
erin.lo@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 02:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
