Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572 ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@12 PS5, Line 12: Tested and working: bluetooth working perfectly (scan, connect, pair etc.); tested with bluetoothctl
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@25 PS5, Line 25: - Wi-Fi card. Probably fixed with correct PCIe settings. working perfectly with iwlwifi and firmware-iwlwifi installed on debian
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@30 PS5, Line 30: - Lid. It was brutally damaged, even though the LCD managed to survive. nope, it's connected to the EC
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@31 PS5, Line 31: - Battery. I have it somewhere. yes but no. it works, but we can't read any values -> EC
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@33 PS5, Line 33: Card reader works fine
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... File src/mainboard/acer/es1-572/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... PS4, Line 129: #| AC LoadLine | 15 mOhm | 5.7 mOhm | 5.2 mOhm | 5.2 mOhm |
I'll discuss psi3/4 defaults with adurbin
see cb:39980