Hello Marco Chen, Jett Rink, Keith Short, Justin TerAvest, Shelley Chen, build bot (Jenkins), Scott Collyer, Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36068
to look at the new patch set (#6).
Change subject: automation: update script and template files for new variant ......................................................................
automation: update script and template files for new variant
create_coreboot_config.sh: * Add a version number for the script and an "auto-generated by" line in the git commit message. * Change the branch name so that it's not the same as the ones that the other scripts will create, so that repo upload on those CLs won't affect this one.
spd/Makefile.inc * Certain upcoming Hatch variants will not use SPD files. Allow SPD_SOURCES to be empty. This means we don't need to update the template Makefile.inc to specify an empty SPD.
baseboard/gpio.h * Define default GPIOs for MEM_CONFIG, variant can redefine these if needed.
baseboard/gpio.c * Add weak function for variant_early_gpio_table so that we don't need a gpio.c unless we're changing the GPIOs.
BUG=b:140261109 BRANCH=None TEST=Create and build the "sushi" variant: $ util/mainboard/google/hatch/create_coreboot_variant.sh sushi $ util/abuild/abuild -p none -t google/hatch -x -a
Prior to this CL, you would get an error message that SPD_SOURCES is not set. If you fixed that, then you would get failures for GPIO_MEM_CONFIG_0, _1, _2, and _3 not defined, and/or gpio_table[] and early_gpio_table[] not defined. After the CL, the build proceeds.
Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1 Signed-off-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/hatch/spd/Makefile.inc M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h M util/mainboard/google/hatch/create_coreboot_variant.sh 4 files changed, 34 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/36068/6