[coreboot-gerrit] [XS] Change in coreboot[master]: mb/google/dedede/var/boxy: Update audio codec HID to use correct ALC5...

[Kevin3 Yang (Code Review)]

Attention is currently required from: Paul Menzel.

Kevin3 Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75813?usp=email )

Change subject: mb/google/dedede/var/boxy: Update audio codec HID to use correct ALC5682I-VD
......................................................................

Patch Set 4:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/75813/comment/f352bc21_702f0bd8 :
PS3, Line 7:  for Boxy
> Redundant.

Done

https://review.coreboot.org/c/coreboot/+/75813/comment/1799e6b1_453adce7 :
PS3, Line 7: Update Audio Codec HID
> Maybe: Update audio codec HID to use correct ALC5682I-VS

Done

https://review.coreboot.org/c/coreboot/+/75813/comment/2fd5320a_e6c0321e :
PS3, Line 9: using
> uses

Done

https://review.coreboot.org/c/coreboot/+/75813/comment/b4782978_72d5ddf4 :
PS3, Line 10: need
> needs

Done

https://review.coreboot.org/c/coreboot/+/75813/comment/fa9e6377_59a39f4c :
PS3, Line 9: Boxy audio codec chip using ALC5682I-VD, not ALC5682I-VS.
           : It need to modify codec HID to "10EC5682" in coreboot to fix audio no output sound issue.
> Please use 72 characters per line.

Done

https://review.coreboot.org/c/coreboot/+/75813/comment/0d48c23e_2dcee6de :
PS3, Line 14: TEST=build and confirm audio can output sound
> Was there any Linux message, that the audio is detected now?

audio soundcard can be list by command "aplay -l"