David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43323 )
Change subject: libpayload: allow nonblocking delay and more than one delay
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/43323/8/payloads/libpayload/arch/x8...
File payloads/libpayload/arch/x86/apic.c:
https://review.coreboot.org/c/coreboot/+/43323/8/payloads/libpayload/arch/x8...
PS8, Line 122: disable_interrupts();
I think it should be there. […]
Ack
https://review.coreboot.org/c/coreboot/+/43323/8/payloads/libpayload/arch/x8...
PS8, Line 127: enable_interrupts();
yes, because in my mind lines 123-126 represent a critical section that ought to be protected with a […]
Good point.
As an aside, perhaps when there are more use cases we'll want to return or block if timer_waiting is already set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib11aeee5b7da81287166ac68fc327e7ae62d1b84
Gerrit-Change-Number: 43323
Gerrit-PatchSet: 8
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Jul 2020 04:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Gerrit-MessageType: comment