Attention is currently required from: hualin wei.
Paul Menzel has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/dedede/var/awasuki: Modify parameters of touchpad I2C ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84898/comment/2e13e463_57b6181f?usp... : PS6, Line 4: hualin wei Please update your Gerrit settings to also use Wei Hualin. (The surname should go second, no idea, which is which.)
https://review.coreboot.org/c/coreboot/+/84898/comment/069362fd_68ea6648?usp... : PS6, Line 7: Modify parameters of touchpad I2C Maybe:
Tune I2C touchpad for freq < 400 kHz and TH > 600 ns
https://review.coreboot.org/c/coreboot/+/84898/comment/b9b46d95_6c4dfb40?usp... : PS6, Line 11: time of high(TH) Please add a space before the (.
File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84898/comment/d575c096_1b492220?usp... : PS6, Line 34: .speed = I2C_SPEED_FAST, : .scl_lcnt = 178, : .scl_hcnt = 92, : .sda_hold = 40, Which of the four values did you have to edit for the frequency and which for time of high?