Attention is currently required from: Saurabh Mishra, Sridhar Siricilla.
Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76111?usp=email )
Change subject: libpayload/arch/x86[INTERNAL]: Update GP register for API handling of CBTABLE handoff
......................................................................
Patch Set 1:
(2 comments)
This change is ready for review.
File payloads/libpayload/arch/x86/head.S:
https://review.coreboot.org/c/coreboot/+/76111/comment/8fb7a3a5_b7bf7907 :
PS1, Line 68: movl %esi, loader_ebx
This is not the one I suggested 😊
Done
https://review.coreboot.org/c/coreboot/+/76111/comment/ab9fb4b3_40866276 :
PS1, Line 72: movl %eax, cb_header_ptr
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76111?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib20d5f68ce60b58533bb048e5363c89a587a1b9b
Gerrit-Change-Number: 76111
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 04:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment