[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )

Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage
......................................................................

Patch Set 5:

The dcache_xxx functions are meant to be callable at any point in common code and do the platform-appropriate thing, so I guess it's true that we can't just have Picasso sidestep every point where it happens to be called. Otherwise we'll keep chasing that whenever we add more cache flushes to common code later (and I assume it's a runtime exception so it wouldn't even be easy to tell that you broke it).

Please don't put a guard around every dcache_xxx call in coreboot either, though, it should be handled inside the function. I guess we need something like CONFIG(ARM_IN_USR_MODE)?